Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Give RunDB an option to find files in storage but not in data… #1248

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dachengx
Copy link
Collaborator

…base in find_several function (#1244)"

This reverts commit 185dad3.

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

…base in find_several function (#1244)"

This reverts commit 185dad3.
@coveralls
Copy link

Coverage Status

coverage: 93.525% (-0.002%) from 93.527% when pulling 6e3e2b3 on revert-1244-check_metadata_rundb into a4b2294 on master.

@dachengx dachengx merged commit 34e12b6 into master Aug 30, 2023
@dachengx dachengx deleted the revert-1244-check_metadata_rundb branch August 30, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants